Github user carsonwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10352#discussion_r48114578
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -115,7 +117,17 @@ class HistoryServer(
}
def getSparkUI(appKey: String): Option[SparkUI] = {
- Option(appCache.get(appKey))
--- End diff --
`appCache.getIfPresent` returns null if there is no cached value for the
appKey. But `appCache.get` will try to obtain that value from a `CacheLoader`,
cache it and return it. So I think we still need use `appCache.get` here and
handle the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
