Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10398#discussion_r48115141
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -253,6 +254,18 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
(1, 1))
}
+ test("MapPartitions can process unsafe rows") {
+ // InMemoryColumnarTableScan's outputsUnsafeRows is unsafe
+ val ds = sparkContext.makeRDD(Seq("a", "b", "c"), 3).toDS().cache()
+ val dsMapPartitions = ds.mapPartitions(_ => Iterator(1))
+ val preparedPlan = dsMapPartitions.queryExecution.executedPlan
+ // unsafe->safe convertor is not inserted between Generate and
InMemoryColumnarTableScan
+
assert(preparedPlan.children.head.isInstanceOf[InMemoryColumnarTableScan])
--- End diff --
how about
`assert(preparedPlan.find(_.isInstanceOf[InMemoryColumnarTableScan]))).isEmpty`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
