Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1256#discussion_r14844587
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -30,6 +30,33 @@ class SparkConfSuite extends FunSuite with
LocalSparkContext {
}
}
+ test("loading from file") {
+ class TestSparkConf(loadDefaults: Boolean, fileName: Option[String])
extends
--- End diff --
This kinda defeats the purpose of testing your code, since you're
overriding the method you should be testing.
Write the test data to a temp file (or load the resource file you're
adding!) instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
