Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10057#discussion_r48192495
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterPersistenceEngine.scala
 ---
    @@ -53,9 +53,12 @@ private[spark] trait MesosClusterPersistenceEngine {
      * all of them reuses the same connection pool.
      */
     private[spark] class ZookeeperMesosClusterPersistenceEngineFactory(conf: 
SparkConf)
    -  extends MesosClusterPersistenceEngineFactory(conf) {
    +  extends MesosClusterPersistenceEngineFactory(conf) with Logging {
     
    -  lazy val zk = SparkCuratorUtil.newClient(conf, 
"spark.mesos.deploy.zookeeper.url")
    +  // TODO(tnachen): Remove support for spark.mesos.deploy.zookeeper.url in 
0.28.
    --- End diff --
    
    same here, no need to do this later. Just do it now. (also this is Spark so 
you should use Spark versions in comments, not Mesos versions)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to