Github user naveenminchu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10403#discussion_r48224194
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -219,13 +219,21 @@ object JdbcUtils extends Logging {
val sb = new StringBuilder()
val dialect = JdbcDialects.get(url)
df.schema.fields foreach { field => {
- val name = field.name
+ val name = dialect.quoteIdentifier(field.name)
val typ: String = getJdbcType(field.dataType,
dialect).databaseTypeDefinition
val nullable = if (field.nullable) "" else "NOT NULL"
sb.append(s", $name $typ $nullable")
}}
if (sb.length < 2) "" else sb.substring(2)
}
+
+ /**
+ * Compute the table name string for this RDD.
+ */
+ def tableString(table: String, url: String): String = {
--- End diff --
@JoshRosen Are you suggesting to build similar logic as spark-redshift has
some fancy logic to handle all of these corner-cases; that you highlighted
databricks/spark-redshift#102 as to how the TableName wrapper works.
Please let me know ur thoughts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
