Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48234838
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -43,12 +45,21 @@ import org.apache.spark.util.Utils
class ClientSuite extends SparkFunSuite with Matchers with
BeforeAndAfterAll {
+ var oldProperties: Properties = null
--- End diff --
That's a fair point -- yes it's called two lines below, right? I think you
could use the standard mechanism in the 2 places you're manually copying the
sys properties?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
