Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-48818275
This looks pretty good to me API-wise, but an Option[Boolean] is kind of
confusing. Maybe we should have an enumeration called SortOrder and pass in an
Option[SortOrder].
Also, when this value is set, please add a check that keyOrdering is also
set. Otherwise the user made an error in configuring the ShuffleDependency but
we'll just return unsorted data.
We should also wait on #931 to be merged and then base this on that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
