Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10391#discussion_r48318003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -456,10 +456,10 @@ case class MapObjects(
($elementJavaType)${genInputData.value}${itemAccessor(loopIndex)};
$loopNullCheck
- if (${loopVar.isNull}) {
+ ${genFunction.code}
+ if (${genFunction.isNull}) {
--- End diff --
Even `loopVar.isNull` is true, we should still call `genFunction` because
it may have special handling for null case, for example `WrapOption` will
produce a `None` for null value. We should depend on `genFunction.isNull` to
decide `$convertedArray[$loopIndex]` is null or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
