Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1338#issuecomment-48818519
This looks awesome, thanks for putting it together! One comment I have
though is that we should add more test coverage, to make sure we cover all the
data types supported. Instead of doing this in doc comments, which gets
unwieldy, you can do it in python/pyspark/tests.py, which is a standalone test
file. Just make sure we have tests that cover each supported data type in
sequence files.
@MLnick you should look at this too when you have a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
