GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/10455
[SPARK-12508][PROJECT-INFRA] Fix minor bugs in
dev/tests/pr_public_classes.sh script
This patch fixes a handful of minor bugs in the
`dev/tests/pr_public_classes.sh` script, which is used by the
`run_tests_jenkins` script to detect the addition of new public classes:
- Account for differences between BSD and GNU `sed` in order to allow the
script to run on OS X.
- Diff `$ghprbActualCommit^...$ghprbActualCommit ` instead of
`master...$ghprbActualCommit`: since `ghprbActualCommit` is a merge commit
which results from merging the PR into the target branch, this will give us the
desired diff and will avoid certain race-conditions which could lead to
false-positives.
- Use `echo -e` instead of `echo` so that newline characters are handled
correctly in output. This should fix a formatting glitch which caused the
output to appear on a single line in the GitHub comment (see [the SC2028
page](https://github.com/koalaman/shellcheck/wiki/SC2028) on the Shellcheck
wiki for more details).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark fix-pr-public-classes-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10455
----
commit dc8d552881a8c0c4ac5a6c7fdac8fd4408911f77
Author: Josh Rosen <[email protected]>
Date: 2015-12-23T19:54:10Z
Fix pr_public_classes script.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
