Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10451#discussion_r48441867
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -153,6 +153,16 @@ object SetOperationPushDown extends Rule[LogicalPlan] 
with PredicateHelper {
             )
           )
     
    +    // Push down limit into union
    +    case Limit(exp, Union(left, right), optimized) if !optimized =>
    --- End diff --
    
    This works, but doesn't look good to me. Actually I don't have a good idea 
for it either, maybe we should just add comments to explain the assumption here.
    
    cc @marmbrus @yhuai 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to