Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10402#discussion_r48495547
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -327,9 +327,9 @@ abstract class OffsetWindowFunction
* both the input and the default expression are foldable, the result is
still not foldable due to
* the frame.
*/
- override def foldable: Boolean = input.foldable && (default == null ||
default.foldable)
+ override def foldable: Boolean = false
- override def nullable: Boolean = input.nullable && (default == null ||
default.nullable)
+ override def nullable: Boolean = default == null || default.nullable
--- End diff --
Just a clarification question. For our current code, `default` will never
be `null`, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
