Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10479#discussion_r48501272
  
    --- Diff: 
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala
 ---
    @@ -70,12 +70,12 @@ class KinesisBackedBlockRDDPartition(
      */
     private[kinesis]
     class KinesisBackedBlockRDD[T: ClassTag](
    -    @transient sc: SparkContext,
    +    sc: SparkContext,
         val regionName: String,
         val endpointUrl: String,
    -    @transient blockIds: Array[BlockId],
    +    blockIds: Array[BlockId],
    --- End diff --
    
    @skyluc @rxin, according to #8433 "if the class parameter are used in 
methods, then fields are created." I'm not sure how this applies in this case, 
where `blockIds` is also the name of a field in the superclass. In #8433, it 
looks like the fix was just to rename `blockIds` to `_blockIds` in order to 
avoid any ambiguity (see 
https://github.com/apache/spark/commit/c1bc4f439f54625c01a585691e5293cd9961eb0c#diff-b936e296c84502986961fb815d642458L64).
 Therefore, I'm going to make the same fix here for consistency's sake. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to