Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10391#discussion_r48501635
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
 ---
    @@ -439,6 +439,13 @@ case class MapObjects(
           s"boolean ${loopVar.isNull} = ${genInputData.isNull} || 
${loopVar.value} == null;"
         }
     
    +    // If lambdaFunction is WrapOption, we will not determine null or not 
based on the
    +    // value of loopVar.isNull, because WrapOption will return None for 
null.
    +    val isWrapOption = lambdaFunction match {
    --- End diff --
    
    I'm not sure exactly what is going on here, but this looks like a hack.  
Ideally this node should not need to know what type its child is to operate 
correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to