Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10451#issuecomment-167845210
Thanks for working on this. I think its getting pretty close. A few minor
cleanups that might be nice:
- I think we should consider pulling all the Limit rules into their own
`LimitPushDown` rule. The reasoning here is twofold: we can clearly comment in
one central place the requirements with respect to implementing maxRows. It
will be easier to turn off if it is ever doing the wrong thing.
- We should do a pass through and add `maxRows` to any other logical plans
where it make sense. Off the top of my head:
- Filter = `child.maxRows`
- Union = `for(leftMax <- left.maxRows; rightMax <- rightMax) yield
Add(leftMax, rightMax)`
- Distinct = `child.maxRows`
- Aggregate - `child.maxRows`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
