Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10421#discussion_r48562209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoiner.scala
---
@@ -171,7 +171,7 @@ object GenerateUnsafeRowJoiner extends
CodeGenerator[(StructType, StructType), U
| // row1: ${schema1.size} fields, $bitset1Words words in bitset
| // row2: ${schema2.size}, $bitset2Words words in bitset
| // output: ${schema1.size + schema2.size} fields,
$outputBitsetWords words in bitset
- | final int sizeInBytes = row1.getSizeInBytes() +
row2.getSizeInBytes();
+ | final int sizeInBytes = row1.getSizeInBytes() +
row2.getSizeInBytes() - ($sizeReduction * 8);
--- End diff --
It may be better to use number of bytes for `sizeReduction` (also update
the comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
