Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/1390#issuecomment-48859675
  
    The code looks good to me. However, I think we can avoid the work around 
solution (de-serializing (with partition serde) and then serialize (with table 
serde) again) for adapting the higher level table scan (`TableScanOperator` in 
Shark), which have to providing a unique `ObjectInspector` for the downstream 
Operators.
    
    Not like `TableScanOperator`, `HiveTableScan` in `Spark-Hive` doesn't reply 
on `ObjectInspector`, 
    and its output type is `GenericMutableRow`, I think we could make the 
object conversion (from raw type to `Row` object) directly.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to