Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/10445#issuecomment-167956491
  
    It seems to me the change is not necessary and might actually complicate 
the analyzer code itself due to the reliance on the dsl implicits and this 
"unapply" (I didn't even know it existed.....)
    
    One thing I do like though is the True and False, although I'd rename it 
TrueLiteral and FalseLiteral, in order to make it clear it is a literal.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to