Github user scwf commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1385#discussion_r14866324
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -552,17 +552,10 @@ class SparkContext(config: SparkConf) extends Logging 
{
           valueClass: Class[V],
           minPartitions: Int = defaultMinPartitions
           ): RDD[(K, V)] = {
    -    // A Hadoop configuration can be about 10 KB, which is pretty big, so 
broadcast it.
    -    val confBroadcast = broadcast(new 
SerializableWritable(hadoopConfiguration))
    -    val setInputPathsFunc = (jobConf: JobConf) => 
FileInputFormat.setInputPaths(jobConf, path)
    --- End diff --
    
    there is no extra reason for broascast Configuration. I think it is because 
the old api here Instantiate HadoopRDD directly and HadoopRDD's construct 
method need broadcastedConf: Broadcast[SerializableWritable[Configuration]], so 
here broadcasted the Configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to