Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10565#discussion_r48699084
  
    --- Diff: dev/run-tests.py ---
    @@ -295,13 +295,14 @@ def exec_sbt(sbt_args=()):
     
     def get_hadoop_profiles(hadoop_version):
         """
    -    For the given Hadoop version tag, return a list of SBT profile flags 
for
    +    For the given Hadoop version tag, return a list of Maven/SBT profile 
flags for
         building and testing against that Hadoop version.
         """
     
         sbt_maven_hadoop_profiles = {
             "hadoop2.2": ["-Pyarn", "-Phadoop-2.2"],
    -        "hadoop2.3": ["-Pyarn", "-Phadoop-2.3", "-Dhadoop.version=2.3.0"],
    --- End diff --
    
    Setting `hadoop.version` is unnecessary here; it's already set in the 
profile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to