Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10541#discussion_r48737999
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -333,6 +333,39 @@ object ProjectCollapsing extends Rule[LogicalPlan] {
             )
             Project(cleanedProjection, child)
           }
    +
    +    // TODO Eliminate duplicate code
    +    // This clause is identical to the one above except that the inner 
operator is an `Aggregate`
    +    // rather than a `Project`.
    +    case p @ Project(projectList1, agg @ Aggregate(_, projectList2, 
child)) =>
    --- End diff --
    
    Will it increase the aggregation buffer? cc @yhuai 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to