Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10498#discussion_r48747698
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
 ---
    @@ -177,3 +179,36 @@ case class Crc32(child: Expression) extends 
UnaryExpression with ImplicitCastInp
         })
       }
     }
    +
    +case class Murmur3Hash(children: Seq[Expression], seed: Int) extends 
Expression {
    +  def this(arguments: Seq[Expression]) = this(arguments, 42)
    +
    +  override def dataType: DataType = IntegerType
    +
    +  override def foldable: Boolean = children.forall(_.foldable)
    +
    +  override def nullable: Boolean = false
    +
    +  override def checkInputDataTypes(): TypeCheckResult = {
    +    if (children.isEmpty) {
    +      TypeCheckResult.TypeCheckFailure("arguments of function hash cannot 
be empty")
    --- End diff --
    
    Nit: hash => Murmur3Hash


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to