Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10529#discussion_r48757529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -104,7 +104,7 @@ class SimpleCatalog(val conf: CatalystConf) extends
Catalog {
val tableName = getTableName(tableIdent)
val table = tables.get(tableName)
if (table == null) {
- throw new NoSuchTableException
+ throw new AnalysisException("Table not found: " + tableName)
--- End diff --
Does this mean that `NoSuchTableException` is not used anywhere? We should
probably get rid of it then. Though, I think I'd have a slight preference for
keeping a special exception internally. The point of this extra control flow
is so that we can attach line position information to this specific exception
in the analyzer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
