Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10534#discussion_r48785603
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -75,7 +77,7 @@ private[spark] class BlockManager(
     
       val diskBlockManager = new DiskBlockManager(this, conf)
     
    -  private val blockInfo = new TimeStampedHashMap[BlockId, BlockInfo]
    +  private val blockInfo = new ConcurrentHashMap[BlockId, BlockInfo]
    --- End diff --
    
    I was worried about the pitfalls of `.getOrElseUpdate` not being atomic on 
`ConcurrentHashMaps` that had been wrapped into Scala maps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to