GitHub user rahulpalamuttam reopened a pull request:
https://github.com/apache/spark/pull/8960
[SPARK-10906][MLlib] More efficient SparseMatrix.equals
@jkbradley
Calls toBreeze.activeIterator which, for CSCMatrix, returns an iterator
with only non zero values. The iterators are then converted to sets and
checked for equality. Since the input parameter can be of type DenseMatrix
the second set is filtered for non-zero values. This is because
activeIterator
for DenseMatrix returns all values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulpalamuttam/spark
RahulP_SparseMatrixEquals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8960.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8960
----
commit f3f7e650455600c0d266395ac549090b959ada95
Author: rahul <[email protected]>
Date: 2015-10-02T01:19:04Z
updated SparseMatrix equal method
commit f9c6ac0795919afedc85d66f246abf933dc0d092
Author: rahul <[email protected]>
Date: 2015-10-09T09:28:24Z
updated SparseMatrix equal method to use iterator traversal.
commit 70016e465c68df1c566e2f5eb44ee19571321312
Author: rahul <[email protected]>
Date: 2015-10-10T00:33:19Z
Updated tests to include 3x3 matrix with more zero elements.
commit 2fff7d74f95242f208874d4f5059e5d86198b8a5
Author: rahul <[email protected]>
Date: 2015-10-10T00:38:06Z
Added tests with identity matrices
commit 7f3f888ff8eb02cdfcbf0f9cad359173154df413
Author: Joseph K. Bradley <[email protected]>
Date: 2015-10-10T02:05:34Z
unit test which fails in MatricesSuite equals
commit b3c29cab43a21dd9626118ca16d0bd7ba2d2ddd7
Author: rahul <[email protected]>
Date: 2015-10-17T00:44:53Z
Updated to handle explicit and implicit zero comparison. Added
corresponding tests.
commit e8821627976936528e55cacf93885ab7ef1ca1cd
Author: rahul <[email protected]>
Date: 2015-10-17T22:27:40Z
Merge branch 'rahulpalamuttam-RahulP_SparseMatrixEquals' of
https://github.com/jkbradley/spark into
jkbradley-rahulpalamuttam-RahulP_SparseMatrixEquals
Conflicts:
mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
