Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10571#discussion_r48846788
--- Diff: project/SparkBuild.scala ---
@@ -443,6 +443,7 @@ object Hive {
val relGFilePath = (gFilePath relativeTo sourceDir).get.getPath
log.info("ANTLR: Grammar file '%s' detected.".format(relGFilePath))
antlr.addGrammarFile(relGFilePath)
+ antlr.setLibDirectory(gFilePath.getParent)
--- End diff --
Tiny thing: By doing this we set the library path multiple times to the
same directory. There is unfortunately not an easy way out of this. The
solution could be to fix the grammar dir, but that would make the build brittle.
Could you add a comment stating that we assume there is only one library
directory?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
