Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1393#discussion_r14916135
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
 ---
    @@ -36,10 +36,10 @@ import org.apache.spark.mllib.api.python.PythonMLLibAPI
      */
     class MatrixFactorizationModel private[mllib] (
         val rank: Int,
    -    val userFeatures: RDD[(Int, Array[Double])],
    -    val productFeatures: RDD[(Int, Array[Double])]) extends Serializable {
    +    val userFeatures: RDD[(Long, Array[Double])],
    +    val productFeatures: RDD[(Long, Array[Double])]) extends Serializable {
       /** Predict the rating of one user for one product. */
    -  def predict(user: Int, product: Int): Double = {
    +  def predict(user: Long, product: Long): Double = {
    --- End diff --
    
    This is also a breaking API change, weird that Jenkins didn't catch it. 
@scrapcodes and @pwendell is this something we're not checking for right now in 
MIMA? Because this class is not experimental or anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to