Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/10611#discussion_r48919311
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -86,7 +86,7 @@ object MLUtils {
val indicesLength = indices.length
while (i < indicesLength) {
val current = indices(i)
- require(current > previous, "indices should be one-based and in
ascending order" )
+ require(current > previous, "indices should be one-based and in
ascending order; found current=" + current + ", previous=" + previous + ";
line=\"" + line + "\"")
--- End diff --
This line is too long (see spark style guide). Also, I recommend you use
scala's string interpolation rather than manually building the string:
```scala
s"previous=$previous, line='$line' "
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
