Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9667#discussion_r48920464
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala 
---
    @@ -122,8 +122,8 @@ class GradientDescent private[spark] (private var 
gradient: Gradient, private va
        * @return solution vector
        */
       @DeveloperApi
    -  def optimize(data: RDD[(Double, Vector)], initialWeights: Vector): 
Vector = {
    -    val (weights, _) = GradientDescent.runMiniBatchSGD(
    +  def optimize(data: RDD[(Double, Vector)], initialWeights: Vector): 
(Vector, Double, Integer) = {
    --- End diff --
    
    This API should not be changed.  You could add a new method 
(```optimizeWithStats```?) which returns the 3 values, and then share the 
implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to