Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10605#issuecomment-169379107
@davies I left some final comments; feel free to use/ignore them.
The benchmark looks good. The shrinking case was expected to perform
horrible, and it does. The other figures are so close to the old figure that I
don't think we can safely say that they are different (given the limited scope
and duration of the test). I was wondering, how does this perform without the
optimized (hybrid) approach?
LGTM (pending review of the ```ExternalSort*``` modifications)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
