Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10570#discussion_r48987891
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -57,8 +57,8 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks {
(result, expected) match {
case (result: Array[Byte], expected: Array[Byte]) =>
java.util.Arrays.equals(result, expected)
- case (result: Double, expected: Spread[Double]) =>
- expected.isWithin(result)
+ case (result: Double, expected: Spread[_]) => // Can't use
Spread[Double] b/c of erasure
--- End diff --
Good point, that seems better. Although it can't actually check the generic
type, leaving it (with the annotation to flag it and silence the warning) at
least better demonstrates the intent. It wouldn't silently pass anyway because
of the following cast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
