Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10562#discussion_r48993960
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1291,11 +1291,11 @@ abstract class RDD[T: ClassTag](
} else {
val buf = new ArrayBuffer[T]
val totalParts = this.partitions.length
- var partsScanned = 0
+ var partsScanned = 0L
--- End diff --
I think there is a legit problem here. Imagine `totalParts` is close to
`Int.MaxValue`, and imagine `partsScanned` is close to `totalParts`. Adding
`p.size` to it below could cause it to roll over. I think this change is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
