Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169506325 @BryanCutler it looks great, thanks! One overall comment about the seeds: it is unclear what `None` means, and it has a different behavior between `spark.ml` and `spark.mllib`. I suggest you mention that if unspecified, the seed is initialized to to the current machine time. (It is a fixed value in `spark.ml`)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org