Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10626#discussion_r49047415
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
    @@ -62,6 +62,32 @@ class DataFrameStatSuite extends QueryTest with 
SharedSQLContext {
         }
       }
     
    +  test("randomSplit on reordered partitions") {
    +    val n = 600
    --- End diff --
    
    sure, that sounds reasonable. The only thing that the old test does that 
this doesn't is that it tests for multiple sampling seeds. I trust that logic 
might've been also tested somewhere else in the physical planner as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to