Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10631#discussion_r49049257
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -301,6 +301,8 @@ trait PrunedScan {
@DeveloperApi
trait PrunedFilteredScan {
def buildScan(requiredColumns: Array[String], filters: Array[Filter]):
RDD[Row]
+ def buildScan(
--- End diff --
this also breaks all existing implementations because we can't add a method
to the interface.
Really - it is really hard to design a public interface that works for
complicated cases (e.g. aggregation) and at the same time can be maintained in
the years to come. If you are only interested in doing this for jdbc, I think
we should consider some hacks to work around the public interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
