Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10655#discussion_r49150950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -321,8 +321,8 @@ private[sql] object DataSourceStrategy extends Strategy
with Logging {
val metadata: Map[String, String] = {
val pairs = ArrayBuffer.empty[(String, String)]
- if (pushedFilters.nonEmpty) {
- pairs += (PUSHED_FILTERS -> pushedFilters.mkString("[", ", ", "]"))
+ if (handledPredicates.nonEmpty) {
+ pairs += (HANDLED_FILTERS -> handledPredicates.mkString("[", ", ",
"]"))
--- End diff --
Should we also keep pushed filters? For some data source like orc, a pushed
filter will be evaluated at a coarse grain level instead of on every rows. I
think it is better to keep that information.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
