Github user yanboliang commented on the pull request:

    https://github.com/apache/spark/pull/10216#issuecomment-169957991
  
    @holdenk Sorry for late response, please see my inline comments. 
    This patch works well, but I think we should to ensure it conforms to the 
structure of the basic design. 
    cc @jkbradley @mengxr for another pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to