Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10520#discussion_r49219243
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -125,6 +125,12 @@ private[hive] object HiveShim {
// for Serialization
def this() = this(null)
+ override def equals(other: Any): Boolean = other match {
+ case a: HiveFunctionWrapper =>
+ functionClassName == a.functionClassName
--- End diff --
@dilipbiswal I feel it is general fine to compare the class name (it is
what we do in 1.5. In 1.5, instance is not a part of the constructor). We added
instance when we added the support of hive's GenericUDFMacro. I guess we can
add a check to see if `GenericUDFMacro` is the class name. If so, we also check
instance. Otherwise, we just use the class name. Also, I guess you need to
override hashCode as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
