Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10541#discussion_r49229231
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -63,7 +63,9 @@ abstract class Optimizer extends 
RuleExecutor[LogicalPlan] {
           RemoveDispensableExpressions,
           SimplifyFilters,
           SimplifyCasts,
    -      SimplifyCaseConversionExpressions) ::
    +      SimplifyCaseConversionExpressions,
    +      // Nondeterministic
    +      ComputeCurrentTime) ::
    --- End diff --
    
    Yea, I think we need to make it evaluated before this batch. Otherwise, 
constant folding rules will fire first, which can potentially introduce problem 
(multiple CurrentTimestamps returns different answers in a query).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to