Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9916#discussion_r49251943
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -317,14 +317,18 @@ class BlockMatrix @Since("1.3.0") (
}
/**
- * Adds two block matrices together. The matrices must have the same
size and matching
- * `rowsPerBlock` and `colsPerBlock` values. If one of the blocks that
are being added are
- * instances of [[SparseMatrix]], the resulting sub matrix will also be
a [[SparseMatrix]], even
- * if it is being added to a [[DenseMatrix]]. If two dense matrices are
added, the output will
- * also be a [[DenseMatrix]].
+ * For given matrices `this` and `other` of compatible dimensions and
compatible block dimensions,
+ * it applies an associative binary function on their corresponding
blocks.
+ *
+ * @param other The BlockMatrix to operate on
--- End diff --
"operate on" sounds like "other" is being modified. Rephrase: "The second
BlockMatrix argument for the operator specified by `binMap`"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
