Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10674#discussion_r49270677
--- Diff: network/common/pom.xml ---
@@ -55,6 +55,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
+ <scope>compile</scope>
--- End diff --
> Isn't compile the default scope? i.e. couldn't you leave out the explicit
compile scope here and just not specify a scope?
> Isn't compile the default scope? i.e. couldn't you leave out the explicit
compile scope here and just not specify a scope?
It's set to `provided` in the parent pom.xml:
https://github.com/apache/spark/blob/b23c4521f5df905e4fe4d79dd5b670286e2697f7/pom.xml#L365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
