Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1387#discussion_r14953877
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskEventListener.scala ---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.scheduler
+
+import java.io.IOException
+import org.apache.spark.{ExceptionFailure, ContextCleaner, Logging,
SparkConf}
+
+private[spark] class TaskEventListener(appName: String, sparkConf:
SparkConf)
+ extends SparkListener with Logging {
+
+ val MAX_PROPORTION = 0.7D
+
+ override def onTaskEnd(taskEnd: SparkListenerTaskEnd) {
+ val SparkListenerTaskEnd(stageId, taskType, reason, taskInfo,
taskMetrics) = taskEnd
+ if (reason.isInstanceOf[ExceptionFailure]) {
+ val ef = reason.asInstanceOf[ExceptionFailure]
+ if ((ef.className == classOf[OutOfMemoryError].getName) ||
ef.className ==
+ classOf[IOException].getName && ef.description.startsWith("No
space left on device")) {
+ ContextCleaner.runGC()
+ }
+ } else if ((taskMetrics != null) && (taskMetrics.jvmGCTime.toDouble /
+ taskMetrics.executorRunTime > MAX_PROPORTION)) {
+ // TODO: Such logic is too rough?
--- End diff --
I don't know. It's still not clear to me what it is that you're trying to
fix. See my question in
https://github.com/apache/spark/pull/1387#issuecomment-49070018; you pasted a
bunch of looks but you haven't explained what the problem is. Is it something
that causes the spark job to do something it shouldn't? Or is it just an ugly
log message you're trying to get rid of?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
