Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r49271654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -523,14 +523,37 @@ class Analyzer(
def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
case s @ Sort(ordering, global, p @ Project(projectList, child))
if !s.resolved && p.resolved =>
- val (newOrdering, missing) = resolveAndFindMissing(ordering, p,
child)
+ val (newOrdering, missing, newChild): (Seq[SortOrder],
Seq[Attribute], LogicalPlan) =
+ child match {
+ case Project(
--- End diff --
and it also becomes more clear later which operator is each
variable/expression for because you will need to specify "p1.projectList",
"w.projectList", etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
