GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/10690
[SPARK-12734][BUILD] Backport Netty exclusion + Maven enforcer fixes to
branch-1.5
This patch backports the Netty exclusion fixes from #10672 to branch-1.5.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark netty-exclude-15-backport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10690
----
commit f4027aa990b50118e9cfac10fadd1b6dd6681f39
Author: Josh Rosen <[email protected]>
Date: 2016-01-11T03:59:01Z
[SPARK-12734][BUILD] Fix Netty exclusion and use Maven Enforcer to prevent
future bugs
Netty classes are published under multiple artifacts with different names,
so our build needs to exclude the `io.netty:netty` and `org.jboss.netty:netty`
versions of the Netty artifact. However, our existing exclusions were
incomplete, leading to situations where duplicate Netty classes would wind up
on the classpath and cause compile errors (or worse).
This patch fixes the exclusion issue by adding more exclusions and uses
Maven Enforcer's [banned
dependencies](https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html)
rule to prevent these classes from accidentally being reintroduced. I also
updated `dev/test-dependencies.sh` to run `mvn validate` so that the enforcer
rules can run as part of pull request builds.
/cc rxin srowen pwendell. I'd like to backport at least the exclusion
portion of this fix to `branch-1.5` in order to fix the documentation
publishing job, which fails nondeterministically due to incompatible versions
of Netty classes taking precedence on the compile-time classpath.
Author: Josh Rosen <[email protected]>
Author: Josh Rosen <[email protected]>
Closes #10672 from JoshRosen/enforce-netty-exclusions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
