Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10604#discussion_r49402268
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -683,9 +685,28 @@ abstract class HadoopFsRelation private[sql](
}
}
- buildInternalScan(requiredColumns, filters, inputStatuses,
broadcastedConf)
+ if (bucketSpec.isEmpty || !sqlContext.conf.bucketingEnabled()) {
+ buildInternalScan(requiredColumns, filters, allInputFiles,
broadcastedConf)
+ } else {
+ // For each bucket id, firstly we get all files belong to this
bucket, by detecting bucket id
+ // from file name. Then read these files into a RDD(use
one-partition empty RDD for empty
+ // bucket), and coalesce it to one partition. Finally union all
bucket RDDs to final result.
+ val perBucketRows = (0 until bucketSpec.get.numBuckets).map {
bucketId =>
+ val inputStatuses = allInputFiles.filter(f => getBucketId(f) ==
bucketId)
--- End diff --
Is getBucketId cheap? Might be nice to just map and collect all the ids
instead of making this O(num buckets * num files)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
