Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10722#discussion_r49498553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -608,7 +609,16 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
case Not(a And b) => Or(Not(a), Not(b))
case Not(Not(e)) => e
+ }
+ }
+}
+/**
+ * Simplifies conditional expressions (if / case).
+ */
+object SimplifyConditionals extends Rule[LogicalPlan] with PredicateHelper
{
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case q: LogicalPlan => q transformExpressionsUp {
case If(TrueLiteral, trueValue, _) => trueValue
case If(FalseLiteral, _, falseValue) => falseValue
--- End diff --
follow-ups: we can add some optimization rules for `CaseWhen`, like remove
some branches if they are foldable and evaluate to false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
