Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10719#issuecomment-171052928
I responded here:
https://github.com/apache/spark/pull/10685#issuecomment-171052858
Pasting the message here too:
@sarutak I actually reverted this change after talking more with Michael
and looking at the diffs. The problem is that for colon, in some cases it is
really useful to have a space before colon. In particular:
In many cases for type bounds, ti is good to have a space before the colon
so it is more clear.
For type descriptions (e.g. variable : Int), it is also often useful to
have a space.
I don't know whether it is feasible to actually implement the rules for the
general colon, but exclude type description and type bounds. If yes, we should
add this enforcement. Otherwise I'd prefer not to have it at all.
For comma, we should always have it (at least I haven't seen a case in
which we don't want it yet).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
