Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10520#discussion_r49553587
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -350,6 +350,13 @@ class HiveUDFSuite extends QueryTest with
TestHiveSingleton with SQLTestUtils {
sqlContext.dropTempTable("testUDF")
}
+ test("Hive UDF in group by") {
+ Seq(Tuple1(1451400761)).toDF("test_date").registerTempTable("tab1")
+ val count = sql("select date(cast(test_date as timestamp))" +
+ " from tab1 group by date(cast(test_date as timestamp))").count()
--- End diff --
Actually it will be good to use withTempTable, which will automatically
drop the temp table. Also, it will be more robust if we create a temp function
based on hive's `org.apache.hadoop.hive.ql.udf.generic.GenericUDFToDate`. So,
even if we later have a native function called date, we can still test the hive
udf. We can do the test change in a follow-up pr (the pr can re-use the jira
number).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
