Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10403#discussion_r49642754
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ---
@@ -40,6 +40,34 @@ private case object MySQLDialect extends JdbcDialect {
override def quoteIdentifier(colName: String): String = {
s"`$colName`"
}
+
+ /**
+ * Process table name in case of containing special characters like dot
seperating database name
+ * followed by table name (eg "some database"."some-table-name") or
+ * in case it contains characters that require quotes (e.g. space).
+ */
+ override def schemaQualifiedTableName(tableName: String): String = {
+ //Removing quotes so that we can add them correctly.
+ val tableNameWithoutQuotes = tableName.replace("\"", "").replace("\'",
"")
+
+ //If block for addressing the case of . (eg "some
database"."some-table-name")
+ if (tableNameWithoutQuotes.contains(".")) {
+ val tableNameList = tableNameWithoutQuotes.split('.')
+ tableNameList.foldLeft("") { (leftStr, rightStr) =>
--- End diff --
I'm still not a fan of this `foldLeft`. Can you please write this in a more
clear way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
