Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10703#discussion_r49649064
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/WriterContainer.scala
---
@@ -324,6 +324,8 @@ private[sql] class DynamicPartitionWriterContainer(
private def bucketIdExpression: Option[Expression] = for {
BucketSpec(numBuckets, _, _) <- bucketSpec
+ // Use `Pmod` to match the behaviour of `Utils.nonNegativeMod`, which is
the function used to
--- End diff --
I don't think this is a good place for this comment. It needs to be with
Pmod and Utils.nonNegativeMod indicating they can't be changed. (Can we also
implement Pmod as just calling Utils.nonNegativeMod?) That will make sure they
stay in sync.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
